bazelbuild / rules_scala

Scala rules for Bazel
Apache License 2.0
363 stars 275 forks source link

Found tool(s) 'external/bazel_tools/tools/zip/zipper/zipper' in inputs. #596

Open iphydf opened 6 years ago

iphydf commented 6 years ago
external/io_bazel_rules_scala/scala/private/rule_impls.bzl", line 106, in _build_nosrc_jar
                ctx.actions.run_shell(inputs = inputs, outputs = outs, com..., <2 more arguments>)
Found tool(s) 'external/bazel_tools/tools/zip/zipper/zipper' in inputs. A tool is 
an input with executable=True set. All tools should be passed using the 
'tools' argument instead of 'inputs' in order to make their runfiles available 
to the action. This safety check will not be performed once the action is 
modified to take a 'tools' argument. To temporarily disable this check, set 
--incompatible_no_support_tools_in_action_inputs=false.
ittaiz commented 6 years ago

Thanks for the report! We'd love a PR to fix this as it sounds a rather small one.

johnynek commented 6 years ago

Also please note the version of bazel you see this. Bazel is very aggressive with deprecations so it is helpful to know what version triggered this warning.

iphydf commented 6 years ago

Version 0.16.1.

ittaiz commented 6 years ago

I looked it up and it started from 0.15.0 On Sun, 26 Aug 2018 at 23:54 iphydf notifications@github.com wrote:

Version 0.16.1.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/bazelbuild/rules_scala/issues/596#issuecomment-416071379, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUIFz9OQkk_LcP-9EoR3sBliVBbZ8Byks5uUwsSgaJpZM4WM11g .

johnynek commented 6 years ago

@iphydf this was an easy fix. I'd invite you to send these PRs. In many cases, the PR is no more work than opening an issue.