search

bazelbuild / rules_swift

Bazel rules to build Swift on Apple and Linux platforms
Apache License 2.0
307 stars 133 forks source link

Fix usage of params files in _swift_proto_compile #1283

Closed bbreier closed 3 weeks ago

bbreier commented 3 weeks ago

I noticed that when I had a long list of deps for a swift_proto_library target, my builds would fail with an error unrecognized argument: --param. This is because protoc expects param files to be prefixed with @ instead of a --param arg. That change + using the multiline file format allows everything to work as intended.

google-cla[bot] commented 3 weeks ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.