search

bazelbuild / rules_typescript

MOVED to https://github.com/bazelbuild/rules_nodejs/tree/3.x/third_party/github.com/bazelbuild/rules_typescript
https://github.com/bazelbuild/rules_nodejs
Apache License 2.0
275 stars 94 forks source link

incompatible_depset_is_not_iterable #443

Closed laurentlb closed 5 years ago

laurentlb commented 5 years ago

According to Bazel CI, this command fails: bazel build... --incompatible_depset_is_not_iterable

File "/home/bazel/.cache/bazel/_bazel_bazel/664e1f005eb545012940353990310184/external/npm_bazel_typescript/internal/common/tsconfig.bzl", line 278, in create_tsconfig
--
  | [((workspace_path + "/") + f.path) for f in files]
  | type 'depset' is not iterable. Use the `to_list()` method to get a list. Use --incompatible_depset_is_not_iterable=false to temporarily disable this check.

Can you take a look at this?

laurentlb commented 5 years ago

I think you need to update the dependency on rules_nodejs.

alexeagle commented 5 years ago

need to cut a rules_nodejs release to get that fix...

alexeagle commented 5 years ago

Okay should be fixed by 09f858aec16969660092cd83d62807247ab11f6e

laurentlb commented 5 years ago

No, there's still an error:

$ bazel build --incompatible_depset_is_not_iterable ... --nobuild
    File "/.../96315885d9b5519569de96c9f8ab613a/external/npm_bazel_typescript/internal/common/tsconfig.bzl", line 278, in create_tsconfig
        [((workspace_path + "/") + f.path) for f in files]
type 'depset' is not iterable. Use the `to_list()` method to get a list. Use --incompatible_depset_is_not_iterable=false to temporarily disable this check.

(cc @vladmos)

laurentlb commented 5 years ago

Since tsconfig.bzl was changed, is it just a matter of updating inter-dependencies between rules_nodejs and rules_typescript, @alexeagle?