Fix wrong format in patch file

meteorcloudy commented 5 years ago

The chuck header format is wrong, which doesn't work with --incompatible_use_native_patch in Bazel.

Attention Googlers: This repo has its Source of Truth in Piper. After sending a PR, you can follow http://g3doc/third_party/bazel_rules/rules_typescript/README.google.md#merging-changes to get your change merged.

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature (please, look at the "Scope of the project" section in the README.md file)
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

alexeagle commented 5 years ago

wait, this patch file was produced with git diff > blah.patch in the other repo. If that pattern doesn't work with Bazel it seems like a big problem? I think it's bazel that should be fixed to work with Git-produced diffs maybe?

meteorcloudy commented 5 years ago

Thanks, indeed, I tested with diff on adding/deleting one liner file. It does output such format, I'll fix this from Bazel side.

meteorcloudy commented 5 years ago

Filed https://github.com/bazelbuild/bazel/issues/9222

bazelbuild / rules_typescript