fix: ts_auto_deps workaround for https://github.com/bazelbuild/bazel/issues/3325 no longer needed - Githubissues

bazelbuild / rules_typescript

MOVED to https://github.com/bazelbuild/rules_nodejs/tree/3.x/third_party/github.com/bazelbuild/rules_typescript

https://github.com/bazelbuild/rules_nodejs

Apache License 2.0

275 stars 94 forks source link

fix: ts_auto_deps workaround for https://github.com/bazelbuild/bazel/issues/3325 no longer needed #467

Closed gregmagolan closed 5 years ago

gregmagolan commented 5 years ago

As part of https://github.com/bazelbuild/rules_nodejs/pull/1042.

--direct_run is now enabled by default in Bazel (https://github.com/bazelbuild/bazel/issues/3325#issuecomment-439815608) so this work-around is no longer needed. The work-around was creating an issue as it was forcing ts_auto_deps to run in the BUILD_WORKING_DIRECTORY in the //e2e:e2e_ts_auto_deps test that was calling bazel run @nodejs//:bin/yarn -- generate_build_file here: https://github.com/bazelbuild/rules_nodejs/pull/1042/files#diff-e90fea9ba9d188bc0409725ef3b89eb0

alexeagle commented 5 years ago

sent a g3sync to @LucasSloan