bazelbuild / rules_typescript

MOVED to https://github.com/bazelbuild/rules_nodejs/tree/3.x/third_party/github.com/bazelbuild/rules_typescript
https://github.com/bazelbuild/rules_nodejs
Apache License 2.0
275 stars 94 forks source link

Remove --incompatible_depset_is_not_iterable #471

Closed laszlocsomor closed 4 years ago

laszlocsomor commented 4 years ago

Remove this flag from the .bazelrc.

Bazel no longer supports this flag, see https://github.com/bazelbuild/bazel/issues/5816

Attention Googlers: This repo has its Source of Truth in Piper. After sending a PR, you can follow http://g3doc/third_party/bazel_rules/rules_typescript/README.google.md#merging-changes to get your change merged.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Using Bazel built from https://github.com/bazelbuild/bazel/commit/8f075d238fa099950b470da2541548d932b2b535, bazel-head info breaks. Culprit is Bazel no longer supports --incompatible_depset_is_not_iterable, added here: https://github.com/bazelbuild/rules_typescript/blob/62bbdc8b3b4f9a8222b135648e8e425e23cad056/.bazelrc#L15

Issue Number: N/A

Did not open any issue, because the bug template asks to open issues with rules_nodejs, but the bug is specific to this repo.

What is the new behavior?

bazel-head info works.

Does this PR introduce a breaking change?

Other information

laszlocsomor commented 4 years ago

Ping, this still shows up on Bazel CI: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1294#d82635ff-91b5-4e76-8149-3cebea573ab9

alexeagle commented 4 years ago

merged as e9b2131da038c7e65dde33c04ee7c5888063827c