bazelbuild / rules_typescript

MOVED to https://github.com/bazelbuild/rules_nodejs/tree/3.x/third_party/github.com/bazelbuild/rules_typescript
https://github.com/bazelbuild/rules_nodejs
Apache License 2.0
275 stars 94 forks source link

presubmit.yml: Remove obsolete incompatible flag #487

Closed laszlocsomor closed 4 years ago

laszlocsomor commented 4 years ago

Bazel 1.0.0 flipped --incompatible_windows_native_test_wrapper and Bazel at HEAD [1] no longer supports it, so Bazel CI with Bazel@HEAD is now broken [2].

[1] https://github.com/bazelbuild/bazel/commits/912e822cd14710b2ebe8c7484c682d627f2906cb [2] https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1359#386d25d4-6fc9-4d49-a0ef-b0fd82bd3dee

Attention Googlers: This repo has its Source of Truth in Piper. After sending a PR, you can follow http://g3doc/third_party/bazel_rules/rules_typescript/README.google.md#merging-changes to get your change merged.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Other information

laszlocsomor commented 4 years ago

Ping, is there anything missing?

c-parsons commented 4 years ago

Friendly ping. This is still failing.

meteorcloudy commented 4 years ago

/cc @alexeagle Can you merge this? We need this to get CI green again.

meteorcloudy commented 4 years ago

Just realized this is synced from Google3, I'm sending a change from internal.