Make rules_typescript compatible with --incompatible_load_proto_rules_from_bzl - Githubissues

bazelbuild / rules_typescript

MOVED to https://github.com/bazelbuild/rules_nodejs/tree/3.x/third_party/github.com/bazelbuild/rules_typescript

https://github.com/bazelbuild/rules_nodejs

Apache License 2.0

275 stars 94 forks source link

Make rules_typescript compatible with --incompatible_load_proto_rules_from_bzl #488

Closed Yannic closed 4 years ago

Yannic commented 4 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature (please, look at the "Scope of the project" section in the README.md file)
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: https://github.com/bazelbuild/bazel/issues/8922 https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/402#72efd01e-eea9-47b4-827e-27edc0f3d9e8

Fixes #476

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information