Add type assertion to JSON.parse. - Githubissues

bazelbuild / rules_typescript

MOVED to https://github.com/bazelbuild/rules_nodejs/tree/3.x/third_party/github.com/bazelbuild/rules_typescript

https://github.com/bazelbuild/rules_nodejs

Apache License 2.0

275 stars 94 forks source link

Add type assertion to JSON.parse. #510

Closed tylerhou closed 4 years ago

tylerhou commented 4 years ago

Attention Googlers: This repo has its Source of Truth in Piper. After sending a PR, you can follow http://g3doc/third_party/bazel_rules/rules_typescript/README.google.md#merging-changes to get your change merged.

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature (please, look at the "Scope of the project" section in the README.md file)
[X] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

With the new JSON.parse rule (https://github.com/bazelbuild/rules_typescript/blob/6a1591b8728f0adb0bda02116801b9b992475035/internal/tsetse/rules/must_type_assert_json_parse_rule.ts), compiler_host fails to compile running under tsetse.

Issue Number: N/A

What is the new behavior?

No new behavior; purely a types change.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information