search

bazelbuild / rules_webtesting

Bazel rules to allow testing against a browser with WebDriver.
Apache License 2.0
97 stars 56 forks source link

Interest in moving go/bazel/bazel.go into rules_go #108

Closed achew22 closed 5 years ago

achew22 commented 7 years ago

I was looking through your code and niticed this utility. I am interested in having access to this in my own code. That made me think it might be useful to upstream into the rules_go repo.

@jayconrod, I would also be interested in your thoughts on this.

jayconrod commented 7 years ago

Seems fine to me, though if it's in rules_go, it shouldn't mention io_bazel_rules_webtesting in DefaultWorkspace. The functions look quite useful for tests though.

bazelbuild/rules_go/go/tools would be a good place for this.

DrMarcII commented 7 years ago

Feel free.

@jayconrod why not just bazelbuild/rules_go/tools (what is the benefit of nesting in go?)?

jayconrod commented 7 years ago

@DrMarcII Consistency, basically. We already have a go/tools directory containing other tools for build, test, and maintenance.

DrMarcII commented 7 years ago

But those are conceptually different tools (in fact, I think most/all of those are binaries). This is a library for use in Bazel projects using go.

joshbruning commented 7 years ago

@achew22 - Should this be closed out or should this library be updated to reference bazelbuild/rules_go?