bazelbuild / rules_webtesting

Bazel rules to allow testing against a browser with WebDriver.
Apache License 2.0
96 stars 56 forks source link

Flag --incompatible_config_setting_private_default_visibility will break rules_webtesting in Bazel 7.0 #446

Open keertk opened 1 year ago

keertk commented 1 year ago

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_webtesting. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: https://github.com/bazelbuild/bazel/issues/12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything. If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

joshbruning commented 1 year ago

This project is on an old rules_go release; after its deps are updated, I think this will be ok

joshbruning commented 1 year ago

I tried building with today's rules_go release; however, there will need to also be a new bazel-gazelle (not yet released) due to (at least) https://github.com/bazelbuild/rules_go/pull/3276

alexeagle commented 1 year ago

@joshbruning hi, are you still a maintainer here? I noticed this issue is 6mo old, I am sure any changes you need from rules_go and bazel-gazelle have been released.

joshbruning commented 1 year ago

No, I haven't been for some years; @mtrea - I think you should try updating the version set and trying a build at least (it may end up being easy); the version diff is getting bigger, and will eventually make the update more difficult to do in one-shot, and there have been an increasing number of linter headaches

sgowroji commented 1 year ago

Hi @joshbruning, Could you please look in to this issue.Thanks!

joshbruning commented 1 year ago

I'm not a maintainer.

sgowroji commented 1 year ago

@mtrea Can you Please have a look on the above failures. Thanks!