search

bazelbuild / stardoc

Stardoc: Starlark Documentation Generator
Apache License 2.0
108 stars 45 forks source link

Flag --incompatible_disable_starlark_host_transitions will break stardoc in Bazel 7.0 #145

Closed keertk closed 1 year ago

keertk commented 1 year ago

Incompatible flag --incompatible_disable_starlark_host_transitions will be enabled by default in the next major release (Bazel 7.0), thus breaking stardoc. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#17032.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything. If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

sgowroji commented 1 year ago

Hi Team, Gentle ping , Can you share any significant update on this issue. Thanks!

tetromino commented 1 year ago

We are not using host transitions in Stardoc itself - but it's used by many of our deps (skylib, rules_license, rules_jvm_external, rules_cc).

We should check whether those projects have releases which work with --incompatible_disable_starlark_host_transitions (for skylib e.g. we need to update to 1.4.1).

tetromino commented 1 year ago

We're blocked by Bazel itself using host transitions in third_party/grpc/build_defs.bzl :)

ERROR: Traceback (most recent call last):
    File "/private/var/tmp/_bazel_arostovtsev/4db74ff3612d0bdc1259d9a6e5cd2136/external/io_bazel/third_party/grpc/build_defs.bzl", line 64, column 30, in <toplevel>
        "_protoc": attr.label(
Error in label: 'cfg = "host"' is deprecated and should no longer be used. Please use 'cfg = "exec"' instead.
ERROR: /private/var/tmp/_bazel_arostovtsev/4db74ff3612d0bdc1259d9a6e5cd2136/external/io_bazel/src/main/java/com/google/devtools/build/lib/collect/nestedset/BUILD:16:13: error loading package '@io_bazel//src/main/protobuf': initialization of module 'third_party/grpc/build_defs.bzl' failed and referenced by '@io_bazel//src/main/java/com/google/devtools/build/lib/collect/nestedset:nestedset'
tetromino commented 1 year ago

Steps to fix: