search

bazelbuild / stardoc

Stardoc: Starlark Documentation Generator
Apache License 2.0
103 stars 40 forks source link

Fix goldens after Bazel change #193

Closed Wyverald closed 5 months ago

Wyverald commented 7 months ago

https://github.com/bazelbuild/bazel/commit/ef457ae14302e22ba217acbe2016a2d7c9630020

tetromino commented 5 months ago

I think the CI failure during the initial attempt to merge this was due to running the test on Bazel 6 instead of 7.

tetromino commented 5 months ago

Ah, I see the problem now. We needed to update not only the test file, but also the update the extractor .jar used in Stardoc's legacy mode (i.e. build the jar using a more recent version of Bazel's source tree).

Closing this PR in favor of https://github.com/bazelbuild/stardoc/pull/198 which does so.