search

bazelbuild / stardoc

Stardoc: Starlark Documentation Generator
Apache License 2.0
103 stars 40 forks source link

Stop explicitly testing PyInfo - it's becoming an ordinary Starlark provider #199

Closed tetromino closed 5 months ago

tetromino commented 5 months ago

We were explicitly testing it until now only because it was a builtin provider; we already have sufficient test coverage for Starlark providers.

Alternative to https://github.com/bazelbuild/stardoc/pull/194

tetromino commented 5 months ago

@rickeylev - does this look reasonable? (For some reason, I cannot add you to reviewers)

rickeylev commented 5 months ago

Yeah I don't have write access. I'm all for removing the python rules as serving as unit tests scaffolding for other things.