bazelbuild / stardoc

Stardoc: Starlark Documentation Generator
Apache License 2.0
108 stars 45 forks source link

Stardoc broken with Bazel@HEAD #253

Closed meteorcloudy closed 2 months ago

meteorcloudy commented 2 months ago

https://buildkite.com/bazel/stardoc/builds/1661

exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //test:repo_rules_test
-----------------------------------------------------------------------------
FAIL: Actual did not match golden.
23c23
< | <a id="my_repo-repo_mapping"></a>repo_mapping |  In `WORKSPACE` settings only: a dictionary from local repository name to global repository name. This allows controls over workspace dependency resolution for dependencies of this repository.<br><br>For example, an entry `"@foo": "@bar"` declares that, for any time this repository depends on `@foo` (such as a dependency on `@foo//some:target`, it should actually resolve that dependency within globally-declared `@bar` (`@bar//some:target`).<br><br>This attribute is _not_ supported in `MODULE.bazel` settings (when invoking a repository rule inside a module extension's implementation function).   | <a href="https://bazel.build/rules/lib/dict">Dictionary: String -> String</a> | optional |  |
---
> | <a id="my_repo-repo_mapping"></a>repo_mapping |  In `WORKSPACE` context only: a dictionary from local repository name to global repository name. This allows controls over workspace dependency resolution for dependencies of this repository.<br><br>For example, an entry `"@foo": "@bar"` declares that, for any time this repository depends on `@foo` (such as a dependency on `@foo//some:target`, it should actually resolve that dependency within globally-declared `@bar` (`@bar//some:target`).<br><br>This attribute is _not_ supported in `MODULE.bazel` context (when invoking a repository rule inside a module extension's implementation function).   | <a href="https://bazel.build/rules/lib/dict">Dictionary: String -> String</a> | optional |  |

Bisect points to https://github.com/bazelbuild/bazel/commit/162298bcb96a553e9e4db48089be0d87d43d358a

/cc @tetromino

meteorcloudy commented 2 months ago

Looks rules_apple was also affected: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4122#0191e992-ff85-4d95-be7a-1054531b7ea3

/cc @keith

meteorcloudy commented 2 months ago

Also rules_dotnet: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4122#0191e993-0abe-47ae-9791-343f297892fd

tetromino commented 2 months ago

Thank you for the bisect! I accidentally introduced a typo into the doc string in Bazel at HEAD. Let me fix it there.

tetromino commented 2 months ago

Should be fixed by https://github.com/bazelbuild/bazel/commit/6045087810e1a9d71e033ecad7cfa68c22d072c0