search

bazelbuild / tulsi

An Xcode Project Generator For Bazel
http://tulsi.bazel.build
Apache License 2.0
547 stars 123 forks source link

Automated rollback of commit fc3edc67433192d4742d80de49a6ffbb58e76d63. #384

Closed thii closed 2 years ago

thii commented 2 years ago

Reason for rollback

Breaks builds for physical device targets running OS versions that do not directly map to floats, e.g. on my phone running iOS 15.6.1:

ValueError: could not convert string to float: '15.6.1'

Original change description

Update the Info.plist mtime of any embedded bundles after copying the Bazel build artifacts over to DerivedData. This matches Xcode behavior and more importantly prevents an issue on iOS 16 or newer devices where incrmeental installations fail due to delta bundles not having a bundle ID because they don't have an Info.plist.

PiperOrigin-RevId: 478566431 (cherry picked from commit b748e0ab3cad1fb681de44a0a028bfccb0681940)

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

thii commented 2 years ago

Also added the reland commit here.