bazelbuild / tulsi

An Xcode Project Generator For Bazel
http://tulsi.bazel.build
Apache License 2.0
548 stars 123 forks source link

incorrect header search paths for external packages #390

Closed Ayatuas closed 2 years ago

Ayatuas commented 2 years ago

Hi, all.

When there are some artifacts produced by objc_library and could be used by Xcode indexing(in my situation, these files are header maps), header search paths should be: bazel-tulsi-includes/x/x/../y.hmap but not (now): bazel-tulsi-includes/x/x/external/y.hmap

Additionally, the contents of header maps could be like: y/y.h -> external/y/path_to/y.h we still need a search path to the external's parent directory for making header maps effective. TULSI_EXECUTION_ROOT seems useless, and TULSI_OUTPUT_BASE works fine.