Closed artasparks closed 6 years ago
The files are fine, but WDYT about adding at least a simple test that uses them in the same PR?
Added a simple test in the workspace.vroom test.
ping
Oh sorry, LGTM. Didn't realize you were waiting for another look.
Add a .gitignore partially based on https://github.com/bazelbuild/bazel/blob/master/.gitignore and also add testdata for Java and CPP from https://github.com/bazelbuild/examples/.
I started to create bespoke test-examples and then realized there are existing examples by the bazel team, so figured it was easier to just copy then to wast time re-creating the wheel!