search

bazelbuild / vscode-bazel

Bazel support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=BazelBuild.vscode-bazel
Apache License 2.0
232 stars 76 forks source link

Revert "Make queries share the same server by default (#270)" #355

Closed cameron-martin closed 4 months ago

cameron-martin commented 4 months ago

This reverts commit 64c9d7eb41bed5a3b9ab67a6423f1f7eee56ed65.

The underlying issue that this addresses is now fixed in Bazel 7.1.0. See #216 and https://github.com/bazelbuild/bazel/pull/21505.

vogelsgesang commented 4 months ago

Do we know which percentage of the user-base of this extension is already using Bazel 7.1? Do we expect everyone to be on the latest version all the time?

From the perspective of most Bazel 7.0 or 6.x users which might not be aware that this issue existed in Bazel < 7.1, this VSCode extension will seem broken. Should we rather auto-detect the Bazel version and set the setting automatically based on that? Or at least display a warning for older Bazel versions?

cameron-martin commented 4 months ago

Good point. I think displaying a message for older versions would be good, since this also has a manual workaround of adding the convenience symlinks to .bazelignore.

cameron-martin commented 3 months ago

@vogelsgesang I've put up a PR to revert this change, plus add some docs in #367.