bazelbuild / vscode-bazel

Bazel support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=BazelBuild.vscode-bazel
Apache License 2.0
231 stars 76 forks source link

Fix protobuffers build by re-enabling `allowJs` #359

Closed vogelsgesang closed 3 months ago

vogelsgesang commented 3 months ago

As part of #358, I removed the allowJs setting from the tsconfig.json. I didn't know why we needed allowJs and everything seemed to still work smoothly.

However, when trying to build the extension from a completely fresh git checkout, I realized that the protos.js file was missing from the out directory. With allowJs: false the src/protos/protos.js file was no longer copied to the out directory. This only worked locally for me, because the current build is not hermetic.