Closed vogelsgesang closed 2 months ago
See https://github.com/microsoft/vscode/issues/209697 for a couple of screenshots
I've reviewed everything but the lcov parser, and it looks good. I've run out of time this evening, so I'll have to review the lcov parser another day.
I am still interested in merging this, but I will wait with resolving the merge conflicts until after the review 🙂
No worries, I know this was a larger, more complicated commit. Thanks for taking the time to review this in-depth instead of just give me a "probably good-enough approval"! Good reviews are important to the project in the long run 🙂
This commit lays the foundation for displaying coverage results from
bazel coverage
.Currently, the functionality is only exposed through the user-defined tasks in the
tasks.json
. It is thereby a bit hard to discover. But this is fine for the time being, because coverage still has a couple of rough edges anyway. As soon as it is more stable, we should add builtin commands and expose coverage runs also in the "Bazel Build Target" tree.Changes in this commit:
replaceAll
which was introduced in ES2021. VS Code 1.88 is based on Node 18 which in turn is based on V8 10.1. V8 10.18 supports ECMA-262 also known as ES2023. However, ES2023 is not yet available a target language in thetsconfig.json
. Furthermore, Firefox does not fully support ES2023, yet. While web browsers are currently not relevant, they might become so in the future if we want to turn this into a browser-enabled VSCode extension. An upgrade to ES2021 would have been sufficient, but I went directly to ES2022 because it might some of the other new features might also turn out useful.:
and / or,
in them.Future work:
Tested with: Java, C++, Go, Rust Untested: Python, Swift, Kotlin, Scala and many more
This is the first step towards #362