search

bazelbuild / vscode-bazel

Bazel support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=BazelBuild.vscode-bazel
Apache License 2.0
231 stars 76 forks source link

fix: Handle relative buildifier path without warning #387

Closed ryanwilsonperkin closed 2 months ago

ryanwilsonperkin commented 2 months ago

Fixes https://github.com/bazelbuild/vscode-bazel/issues/386

Relative paths for buildifier are now supported as of v0.10.0, the warning should not be shown when the buildifier executable exists at the relative path specified.

BEGIN_COMMIT_OVERRIDE fix(buildifier): Handle relative buildifier path without warning #387 END_COMMIT_OVERRIDE

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ryanwilsonperkin commented 2 months ago

(Haven't contributed previously or written VSCode extensions, would appreciate any feedback from the maintainers on how best to setup for testing this)

vogelsgesang commented 2 months ago

I just saw that our CI doesn't like the code formatting... You can run npm run format-fix to fix the formatting

ryanwilsonperkin commented 2 months ago

Thanks for the feedback @vogelsgesang ! Pushed some fixes

vogelsgesang commented 2 months ago

Looks good to me, thanks again!

vogelsgesang commented 2 months ago

The next release to the Marketplace will probably still be a while. In the meantime, you can get a prebuilt pre-release version from the GitHub Action artifacts