bazelbuild / vscode-bazel

Bazel support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=BazelBuild.vscode-bazel
Apache License 2.0
231 stars 76 forks source link

fix: Default to Python syntax highlighting theme #397

Closed nicolasstucki closed 1 month ago

nicolasstucki commented 1 month ago

This fixes #396. Changes the .starlark name suffix to .python.starlark.

By using both python and starlark, vscode is able to default to Python highlighting if a color theme defines colors specifically for python. For example, default color themes in vscode use keyword.operator.logical.python to highlight and/or/not/in.

cameron-martin commented 1 month ago

I know almost nothing about textmate grammars, but it looks reasonable on the face of it.

vogelsgesang commented 1 month ago

Thanks again for the pull request, @nicolasstucki! Merged 🙂