Closed mmizutani closed 3 years ago
Thank you for updating the CI settings. I will look into the errors: https://app.circleci.com/pipelines/github/bazelruby/rules_ruby/307/workflows/bdd3ad88-e478-4e37-8029-b16e3ef1b38e/jobs/1073
@mmizutani Keep in mind that ruby version went up to 3.0.1 across the board. Perhaps you might want to update it as well, so that on CI we don't need to build a 2.7 interpreter. The 3.0.1 is pulled with the Docker image.
This, once ready, will be the 0.5.1 release.
Let me know if you'd like to pair on figuring out the broken build issues. I am in San Francisco time zone.
The tests have now been fixed. Thank you for your advice.
Amazing!
This PR fixes the gem registration logics to load all of the paths specified in the
require_paths
property of gemspecsinstead of loading only the standard, hardcoded path
["lib"]
.Also, this PR extends
ruby_bundle
rule to also acceptincludes
option, which allows us to specify additional library load paths not listed in the gemspecs'require_paths
for specific rubygems like this:With both
includes
andexcludes
per-gem options at hand, users ofruby_bundle
rule have more granular control over gem load paths, possibly addressing issues #85 , #86 , #97.