search

bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts
MIT License
250 stars 121 forks source link

Check for loops in the export graph #163

Closed johnynek closed 6 years ago

johnynek commented 6 years ago

@ianoc-stripe noticed an infinite loop in #162.

The bug can be fixed by tracking for each node if we are working on it, and if so, who depends on it. If we find a loop, we stop and report the loop.

Adding the error handling complicates it quite a bit, but we should be handling this error in a nice way rather than a stack overflow.

ianoc-stripe commented 6 years ago

👍 thanks!