search

bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts
MIT License
250 stars 122 forks source link

Bump rules_scala #242

Closed mjduijn closed 5 years ago

mjduijn commented 5 years ago

Now builds without warnings in Bazel 0.23.0

Resolves #241

johnynek commented 5 years ago

Thank you so much!

I think we will need to bump the travis CI version of bazel used: https://github.com/johnynek/bazel-deps/blob/master/.travis.yml

I guess at least 0.22 will be required.

Jdban commented 5 years ago

You could do something like startup-os does where the bazel version is specified in a .bazelversion file and automatically downloaded and used via the tools/bazel script.

That way, CI and all local builds use the same version bazel and it can be changed easily across branches. You might want to remove the rm line though b/c it's annoying locally if the version gets deleted and redownloaded when switching branches.

https://github.com/google/startup-os/blob/ceac236a2d6d3f1b95d8da9d1f044f30d9a4680c/tools/bazel

mjduijn commented 5 years ago

I could also include a Bazel version check from bazel-skylib.

load("@bazel_skylib//lib:versions.bzl", "versions")

versions.check(minimum_bazel_version = "0.22.0")

@johnynek your call

johnynek commented 5 years ago

Happy to take the version check in a follow up if you like.

Thank you!

thundergolfer commented 5 years ago

@mjduijn cheers!