Closed mjduijn closed 5 years ago
Thank you so much!
I think we will need to bump the travis CI version of bazel used: https://github.com/johnynek/bazel-deps/blob/master/.travis.yml
I guess at least 0.22 will be required.
You could do something like startup-os does where the bazel version is specified in a .bazelversion
file and automatically downloaded and used via the tools/bazel
script.
That way, CI and all local builds use the same version bazel and it can be changed easily across branches. You might want to remove the rm
line though b/c it's annoying locally if the version gets deleted and redownloaded when switching branches.
https://github.com/google/startup-os/blob/ceac236a2d6d3f1b95d8da9d1f044f30d9a4680c/tools/bazel
I could also include a Bazel version check from bazel-skylib.
load("@bazel_skylib//lib:versions.bzl", "versions")
versions.check(minimum_bazel_version = "0.22.0")
@johnynek your call
Happy to take the version check in a follow up if you like.
Thank you!
@mjduijn cheers!
Now builds without warnings in Bazel 0.23.0
Resolves #241