Bazel 0.25.x compatibility (#253)

bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts

MIT License

250 stars 122 forks source link

Bazel 0.25.x compatibility (#253) #254

Closed sholokhov closed 5 years ago

sholokhov commented 5 years ago

Bump io_bazel_rules_scala version
Add external dependency on protobuf

Tested with bazel 0.25.2.

P.S. I was forced to add protobuf dependency because otherwise it fails with no such package '@com_google_protobuf//': The repository '@com_google_protobuf' could not be resolved and referenced by '//external:io_bazel_rules_scala/dependency/com_google_protobuf/protobuf_java'.

johnynek commented 5 years ago

Thanks. It looks like we have to change the Travis setting to use openjdk or some other approach.

I appreciate your PR! If you have time to fix the Travis thing. I would be greatly appreciative, otherwise I can take a look after I finish some traveling I’m doing.

sholokhov commented 5 years ago

@johnynek no problem, I've fixed CI (switched to openjdk11 and updated bazel installer).

johnynek commented 5 years ago

Wonderful! Thanks so much.