Closed thundergolfer closed 5 years ago
sorry for the latency.
I'd be happy to merge the PR with the fix. It would be good if we could find some way to test and show the previous bug so we can prevent future regressions.
About the protobuf hack, I don't think I want to merge that. I think if we could encapsulate it somehow in rules scala inside of a function that users could call in their repo as needed, but I don't want to cargo-cult weird workarounds.
About the protobuf hack, I don't think I want to merge that. I think if we could encapsulate it somehow in rules scala inside of a function that users could call in their repo as needed, but I don't want to cargo-cult weird workarounds.
😄 I definitely wasn't intending that to enter this PR. I was trying something last night and forgot I had the PR pointing at :master
.
Closing to reopen this change request from a PR-specific branch.
Extra conditional to fix bug intro'd by https://github.com/johnynek/bazel-deps/pull/251
This change was originally suggested by @Reflexe in the thread, but they didn't make a PR for it. https://github.com/johnynek/bazel-deps/compare/master...Reflexe:master