search

bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts
MIT License
250 stars 122 forks source link

Fix small bug intro'd in PR #251 #267

Closed thundergolfer closed 5 years ago

thundergolfer commented 5 years ago

Note: Previously this change request was opened as https://github.com/johnynek/bazel-deps/pull/266, but I'm redoing it to avoid using my fork's master branch.

Extra conditional to fix bug intro'd by https://github.com/johnynek/bazel-deps/pull/251

This change was originally suggested by @Reflexe in the thread, but they didn't make a PR for it. https://github.com/johnynek/bazel-deps/compare/master...Reflexe:master

thundergolfer commented 5 years ago

@johnynek happy to look at getting a test case for this.

johnynek commented 5 years ago

I’ll merge and we can follow with another PR as needed.