search

bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts
MIT License
250 stars 122 forks source link

S3 maven artifacts support #275

Open gmendonca opened 4 years ago

gmendonca commented 4 years ago

Not sure if useful, but I had the same problem with sbt. When trying to resolve maven artificats from a private s3 path, the CouriserResolver would fail. For sbt this problems was solved by https://github.com/frugalmechanic/fm-sbt-s3-resolver

I pretty much hacked its code into CoursierResolver to unblock myself into using bazel-deps. I decided to share in case anyone bumps into the same problem. I'm not sure if this is the way to go, but I'll be happy to do any modifications if this is useful.

johnynek commented 4 years ago

So, the more I think about it, the more this seems like an issue for coursier.

Have you thought of opening an issue there?

gmendonca commented 4 years ago

Yeah, this was my first thought but then I found this https://github.com/coursier/coursier/issues/164 and decided to do it here. But maybe it wasn't a good call, I'll read more and if that's the case, I'll open an issue there.

gmendonca commented 4 years ago

About using the original code: It was designed sbt plugin and it has a different naming pattern, so not sure how resolve this dependency throught bazel: https://stackoverflow.com/a/54585431/4051109

Probably a dead end :(

gmendonca commented 4 years ago

FYI: https://github.com/coursier/coursier/issues/1488