bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts
MIT License
250 stars 122 forks source link

Update rules_scala to pull in https for central.maven.org #277

Closed yonajune closed 4 years ago

yonajune commented 4 years ago

Trying to pull in https://github.com/bazelbuild/rules_scala/pull/920

Changes since the last update: https://github.com/bazelbuild/rules_scala/compare/0f89c21...a676633

yonajune commented 4 years ago

Nice. Did they publish it?

(Assuming you mean rules_scala)

Very little context, so happy to be corrected. I think git_repository function used here based on the Bazel docs just needs the commit SHA to be updated, which I provided.

radix-aw commented 4 years ago

@yonajune Thank you for this. Looking forward to it being merged ASAP.

johnynek commented 4 years ago

thanks for the PR!