Fix 'else' branch of conditional in update_dependencies.sh

bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts

MIT License

249 stars 121 forks source link

Fix 'else' branch of conditional in update_dependencies.sh #288

Closed thundergolfer closed 4 years ago

thundergolfer commented 4 years ago

Description

Currently if the else branch is run bash will attempt to run the string as a command.

thundergolfer commented 4 years ago

I think variable usages like $REPO_ROOT here:

\$BAZEL_DEPS_PATH generate -r \$REPO_ROOT ...

should be quoted as the path could contain spaces.

ianoc commented 4 years ago

Thanks for the fix!, if you have time/see those ones would appreciate any more PR's doing the quoting.

johnynek commented 4 years ago

@thundergolfer thanks! to be clear we welcome reviews and contributions! Would love any help you have to make the tool more usable, featureful and correct.