search

bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts
MIT License
249 stars 121 forks source link

Add authentication file support #293

Closed lgirault closed 3 years ago

lgirault commented 3 years ago

This is useful to access private repositories. Also support a $env_var format for better flexibility

ianoc commented 3 years ago

@lgirault this looks good to me, but could you add a test? it doesn't seem that the new parsing code is covered in a test now I believe.

Something in https://github.com/johnynek/bazel-deps/blob/120e27a76a8bfa367ce4f1b6860a9530b84731bc/test/scala/com/github/johnynek/bazel_deps/ParseTest.scala

lgirault commented 3 years ago

Sure ! Is that enough ?

lgirault commented 3 years ago

I'm not sure what to do. I think the broken test is not linked to my PR. Furthermore, locally I ran it twice: it failed once and passed once. I'll try to investigate it as soon as I have some free time

ianoc commented 3 years ago

Does seem unrelated to your change, i restarted the build and its passed now. So i'm going to merge this.

Thanks for the contribution! Sorry again for the slow replies