search

bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts
MIT License
249 stars 121 forks source link

format-deps drops generateNeverlink #298

Closed mcamenzind closed 3 years ago

mcamenzind commented 3 years ago

Executing format-deps on the dependencies.yaml file removes the generateNeverlink: True.

How to reproduce ~/.bazel-deps-cache/v0.1-9 format-deps -d "$REPO_ROOT/$DEPENDENCIES_FILE" -o

You will notice that the manually added generateNeverlink entries were dropped.

johnynek commented 3 years ago

Looks like toDoc here ignores that field:

https://github.com/johnynek/bazel-deps/blob/3bed1b71bf94a62b566d6d98f119f2708b28c367/src/scala/com/github/johnynek/bazel_deps/DepsModel.scala#L683

would be an easy fix.

Do you want to send a PR?

mcamenzind commented 3 years ago

Do you want to send a PR?

Sent!