search

bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts
MIT License
249 stars 121 forks source link

Make targets for replacements have public visibility #302

Closed akakitani closed 3 years ago

akakitani commented 3 years ago

Fixes https://github.com/johnynek/bazel-deps/issues/173

For targets specified under replacements, this makes the corresponding 3rdparty/jvm targets have public visibility.

This addresses behavior that I've found to be counterintuitive with strictVisibility enabled. I'd expect all dependencies declared in a dependencies.yaml to be visible to the workspace, regardless of whether it's under dependencies or replacements.

johnynek commented 3 years ago

thanks!