bazeltools / bazel-deps

Generate bazel dependencies for maven artifacts
MIT License
250 stars 121 forks source link

bazel-deps completely ignores verbosity settings #385

Open grepwood opened 2 months ago

grepwood commented 2 months ago

I've tried to run:

bazel-bin/tools/bazeldeps generate -v error ...

and

bazel-bin/tools/bazeldeps generate -v trace ...

and they both print the same message:

wrote 414 targets

The same applies to bazel-bin/tools/bazeldeps format-deps - setting -v to any value does absolutely nothing.

johnynek commented 2 months ago

here is the entirety of how this setting is used:

https://github.com/bazeltools/bazel-deps/blob/2939a582d75511cd6141df8b6cb2df81302fe909/src/scala/com/github/johnynek/bazel_deps/ParseProject.scala#L17

but the example you give (wrote X targets) is just a println:

https://github.com/bazeltools/bazel-deps/blob/2939a582d75511cd6141df8b6cb2df81302fe909/src/scala/com/github/johnynek/bazel_deps/MakeDeps.scala#L77

so, this is really about plumbing through messages to the slf4j and I guess not enough use of that library was done, OR perhaps the whole mechanism of setting the logging level was incorrectly handled.

grepwood commented 2 months ago

I see. I see. I broke something on purpose now, and I'm getting [io-compute-blocker-2] ERROR MakeDeps spam regardless of settings.