search

bazmonk / digigurdy-baz

DigiGurdy Teensy Code
MIT License
16 stars 10 forks source link

Fix display menu #78

Closed SalusaSecondus closed 2 years ago

SalusaSecondus commented 2 years ago

Display menu incorrectly checks for myOkButton rather than my1Button being pressed (as documented in menu text). This fixes that.

It has been tested on my instrument

Gubbledenut commented 2 years ago

Looks like you are using ver 1.0, this have been fixed .. look in the testing branch for ver 1.4 is the latest..with lots of extra goodies

SalusaSecondus commented 2 years ago

Thank you. I'll upgrade my gurdy today. We might still want to merge this patch as it looks like John is using the main branch to load the gurdies he ships.

bazmonk commented 2 years ago

Yeah, the 'testing' branch is what I'm using as the latest branch right now. Task #1 when I get back into this is to bring the main branch up to date.

-Baz

On Thu, May 19, 2022 at 7:14 AM Greg Rubin @.***> wrote:

Thank you. I'll upgrade my gurdy today. We might still want to merge this patch as it looks like John is using the main branch to load the gurdies he ships.

— Reply to this email directly, view it on GitHub https://github.com/bazmonk/digigurdy-baz/pull/78#issuecomment-1131752777, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX5QOHYBCM6R5BIL7BAAY33VKZEDRANCNFSM5WK2ILLQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

bazmonk commented 2 years ago

I was making changes pretty rapidly a few weeks/month ago, and I think John didn't want to jump on the latest version I whipped up with each gurdy, you know?

On Thu, May 19, 2022 at 8:19 AM Basil Lalli @.***> wrote:

Yeah, the 'testing' branch is what I'm using as the latest branch right now. Task #1 when I get back into this is to bring the main branch up to date.

-Baz

On Thu, May 19, 2022 at 7:14 AM Greg Rubin @.***> wrote:

Thank you. I'll upgrade my gurdy today. We might still want to merge this patch as it looks like John is using the main branch to load the gurdies he ships.

— Reply to this email directly, view it on GitHub https://github.com/bazmonk/digigurdy-baz/pull/78#issuecomment-1131752777, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX5QOHYBCM6R5BIL7BAAY33VKZEDRANCNFSM5WK2ILLQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

SalusaSecondus commented 2 years ago

Oh, I completely get it. Rapidly moving code bases are tough to work on. Feel free to close this if that's the better path. Now that I've loaded testing on my instrument and have a dev environment up, I'll probably stay pretty close to HEAD on testing because why not?