Move environment variable constants name into orchestration/paths

bazooka-ci / bazooka

Continuous Integration and Continuous Deployment Server

http://docs.bazooka-ci.io/

MIT License

60 stars 5 forks source link

Move environment variable constants name into orchestration/paths #176

Closed haklop closed 9 years ago

haklop commented 9 years ago

Some input environment variables were missing in orchestration/paths.go

julienvey commented 9 years ago

I'm not sure this was a miss by @jawher

The constants in orchestration/paths.go are those related to a path, whereas BazookaEnvSCM, BazookaEnvSCMUrl, BazookaEnvSCMReference, BazookaEnvProjectID, BazookaEnvJobID are not paths, so they should still belong in orchestration/main.go IMO

jawher commented 9 years ago

Yep, I only moved path related variables to paths.go. It was intentional.

Later, we might organize and group env vars into an Env struct in a env.go file for example.