search

bazooka-ci / bazooka

Continuous Integration and Continuous Deployment Server
http://docs.bazooka-ci.io/
MIT License
60 stars 5 forks source link

Update generator to manage changes in working directory #255

Closed julienvey closed 8 years ago

julienvey commented 9 years ago

Resolves #251

haklop commented 9 years ago

+1

jawher commented 9 years ago

I'm not sure this is a good idea.

I agree that it is convenient for the user, but less so for us, i.e. we lose control of the overall execution.

For example, if exit is called from one of the sourced scripts (which are user-settable), the whole build script exits, and we don't get a chance to run the after_* steps.

Maybe a better solution would be to expose a working_dir config key in the .bazooka.yml file ?

julienvey commented 9 years ago

I will rework this soon

julienvey commented 8 years ago

Came with a new implementation using a static file /.bzkenv to persist the working directory between phases

julienvey commented 8 years ago

Spaces in a file name would break the implementation

julienvey commented 8 years ago

I fixed the space problem using echo "cd \"$(pwd)\"" > /.bzkenv

Should be all good now

julienvey commented 8 years ago

We decided to merge this one and fix the last issue in the upcoming PR using templates