Width calculation only is correct when the view takes up the whole width of the screen.

bazookon / giphy_get

Flutter plugin

MIT License

27 stars 67 forks source link

Width calculation only is correct when the view takes up the whole width of the screen. #19

Closed m-j-g closed 2 years ago

m-j-g commented 2 years ago

Nice work on the bottom modal.
There is an issue with the width calculation anytime the view doesn't take up the full screen (landscape tablets or web implementations). line 91 in giphy_tab_detail.dart is using (MediaQuery.of(context).size.width which is simply the width of the screen and not the width of the view. Using a LayoutBuilder to get the constraints maxwidth would fix this issue.

bazookon commented 2 years ago

thank's, can you make a pull request fixing this issue?

bazookon commented 2 years ago

hello @m-j-g can you test this version if this issue has fixed?

bazookon commented 2 years ago

fixed in version 3.0.1