search

baztian / jaydebeapi

JayDeBeApi module allows you to connect from Python code to databases using Java JDBC. It provides a Python DB-API v2.0 to that database.
GNU Lesser General Public License v3.0
365 stars 148 forks source link

Update to support jpype 0.7.2+ #135

Closed khangp0000 closed 4 years ago

khangp0000 commented 4 years ago

Use .class_ instead of javaclass and call getFields(). Exception handler use isinstance() to check for Exception.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

baztian commented 4 years ago

Thank you! Did you try it with both: old and new JPype versions? Sorry, I don't have that much time currently and the travis build is currently broken... Can you please report the results of the last JPype versions?

khangp0000 commented 4 years ago

I only modify the code part for 7.0+, so it should be working with both versions. I only test it on 7.2 for new Jpype, but it should work if JPype keep the same API and have the usual version syntax.

On Wed, May 20, 2020, 05:57 baztian notifications@github.com wrote:

Thank you! Did you try it with both: old and new JPype versions? Sorry, I don't have that much time currently and the travis build is currently broken... Can you please report the results of the last JPype versions?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/baztian/jaydebeapi/pull/135#issuecomment-631456455, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPPHQPTKMPLQ3BYNSL67Z3RSPHSJANCNFSM4MP2OU3Q .

baztian commented 4 years ago

OK, doing a dry run test at least the old version should work. I'll merge it. Thanks again!