bazz1tv / ayumi

My lovely IRC bot :sparkles: :turtle: :mailbox: :sparkles:
0 stars 1 forks source link

adds basic testing against Game object's core functionality #97

Open TheNotary opened 8 years ago

TheNotary commented 8 years ago

This is NOT something I would consider a finished commit. I think sorting out the hoisting scenerio so that all of the rb files are loaded when ayumi is first loaded should be looked into before going too much further so we don't have to run into the same problems when testing teh other plugins. Plus alimenting the need to define plugin names in a config file is nice since it means you have to not only add the plugin file to the repo but take the additional time of updating the configuration file.

bazz1tv commented 8 years ago

This is NOT something I would consider a finished commit. I think sorting out the hoisting scenerio so that all of the rb files are loaded when ayumi is first loaded should be looked into before going too much further so we don't have to run into the same problems when testing teh other plugins.

I will look into this.

Plus alimenting the need to define plugin names in a config file is nice since it means you have to not only add the plugin file to the repo but take the additional time of updating the configuration file.

I made a comment on #96 elaborating my approach and offering a solution. Please check into that.

This is a good PR so far dude~ nice work!

Other thoughts

have more organized folder structure in the spec folder, for example to distinguish tests of the bot, test of plugins, and other points of organization.