search

bb-Ricardo / check_redfish

A monitoring/inventory plugin to check components and health status of systems which support Redfish. It will also create a inventory of all components of a system.
MIT License
115 stars 34 forks source link

Feature Request: New parameter to escalate severity of 'Failure Predicted' status #126

Closed SirScruffy closed 9 months ago

SirScruffy commented 9 months ago

Hi Ricardo,

following the EOL announcement of Dell OpenManage, we decided to run our hardware monitoring completely with check_redfish. We noticed that hard disks with the status 'Failure Predicted: true' are only declared as a 'warning'. Would it be possible to add a parameter to report this status as 'critical'?

The reason for this is that we want to prevent a hard disk from going to 'Failure Predicted: true' while under warranty and then failing completely much later (possibly outside the warranty).

I can provide you with a mockup of a server where a hard disk has this status, if you need it.

Cheers Scruffy

bb-Ricardo commented 9 months ago

Hi, good point. I would assume it is helpful for a lot of people to change this status to Critical for all users.

Will have a look at it.

bb-Ricardo commented 9 months ago

Hi, this was a quick one :D

I just pushed a change to next-release branch. Can you check it out and test it please?

SirScruffy commented 9 months ago

Hi,

thanks for the FAST response/patch :D I tested it and it works perfectly.

Thank you very much!

Cheers Scruffy

bb-Ricardo commented 9 months ago

Thank you for testing, will create a new release containing this change.

bb-Ricardo commented 9 months ago

I also accept GitHub :star: as "payment".