search

bb-Ricardo / check_redfish

A monitoring/inventory plugin to check components and health status of systems which support Redfish. It will also create a inventory of all components of a system.
MIT License
115 stars 34 forks source link

Options --firmware/--storage together with --detailed : output unnecessary data #131

Closed Aleksey-Maksimov closed 2 months ago

Aleksey-Maksimov commented 4 months ago

Hello.

Thank you for the useful plugin. We have found one problem. If we use the --firmware and --detailed options together, the plugin outputs information about empty disk slots on the server.

For example, in our Cisco WSA S695 server (Cisco UCS C240 ​​M5 Server), the disk enclosure has 26 disks, but only 2 disks are used (1 and 2).

# ./check_redfish.py --host cimc001.holding.com --username monitor --password 'mypwd' --nosession --info --firmware --detailed

[OK]: INFO: Cisco Systems Inc S695 (CPU: 2, MEM: 256GB) - BIOS: C240M5.3.1.3h.0.0810190451 - Serial: WZPXXXXXXXX - Power: On - Name: CIMC001
[OK]: Found 35 firmware entries.
[OK]: BIOS: C240M5.3.1.3h.0.0810190451
[OK]: Board_Controller: 52.0
[OK]: CIMC: 4.3(2.240053)
[OK]: Drive 1 (6) (1): W150
[OK]: Drive 10 (15) (10): None
[OK]: Drive 11 (16) (11): None
[OK]: Drive 12 (17) (12): None
[OK]: Drive 13 (18) (13): None
[OK]: Drive 14 (19) (14): None
[OK]: Drive 15 (20) (15): None
[OK]: Drive 16 (21) (16): None
[OK]: Drive 17 (22) (17): None
[OK]: Drive 18 (23) (18): None
[OK]: Drive 19 (24) (19): None
[OK]: Drive 2 (7) (2): W150
[OK]: Drive 20 (25) (20): None
[OK]: Drive 21 (26) (21): None
[OK]: Drive 22 (27) (22): None
[OK]: Drive 23 (28) (23): None
[OK]: Drive 24 (29) (24): None
[OK]: Drive 25 (30) (25): None
[OK]: Drive 26 (31) (26): None
[OK]: Drive 3 (8) (3): None
[OK]: Drive 4 (9) (4): None
[OK]: Drive 5 (10) (5): None
[OK]: Drive 6 (11) (6): None
[OK]: Drive 7 (12) (7): None
[OK]: Drive 8 (13) (8): None
[OK]: Drive 9 (14) (9): None
[OK]: Power Supply PS-2112-9S-LF (34) (Slot 1): 10062019
[OK]: Power Supply PS-2112-9S-LF (35) (Slot 2): 10062019
[OK]: SasExpM5: 65.11.21.00
[OK]: Storage Controller Cisco 12G Modular Raid Controller with 4GB cache (max 26 drives) (32): 51.23.0-5009
[OK]: UCSC-PCIE-IRJ45-slot-1: 0x800011A4-1.831.2
[OK]: UCSC-RAID-M5HD-slot-MRAID: 51.23.0-5009

The plugin outputs unnecessary extra information about empty slots in the disk enclosure. And by the way, there is a similar problem when using the --storage and --detailed options together. Can you fix this?

bb-Ricardo commented 4 months ago

Hi,

Cisco is not quite following the standard, that's why these drives show up.

Can you create a Redfish Mockup of one of these servers and send it to me please. Just look for Redfish Mockup generator.

Thank you

Aleksey-Maksimov commented 4 months ago

Can you create a Redfish Mockup of one of these servers and send it to me please. Just look for Redfish Mockup generator.

Tell me an example of how I can do this

cschug commented 4 months ago

I would guess https://github.com/DMTF/Redfish-Mockup-Creator is meant here which also provides usage instructions.

bb-Ricardo commented 4 months ago

I would guess https://github.com/DMTF/Redfish-Mockup-Creator is meant here which also provides usage instructions.

Thank you, that's the one.

bb-Ricardo commented 3 months ago

Hi, did you have a chance to create a MockUp?