bb-Ricardo / check_redfish

A monitoring/inventory plugin to check components and health status of systems which support Redfish. It will also create a inventory of all components of a system.
MIT License
115 stars 34 forks source link

fix critical and warning limits not working on log entries for HPE #133

Closed Gibheer closed 3 months ago

Gibheer commented 3 months ago

When the critical and warning levels are set for event log entries they get converted into date limits. But these limits had no effect when used on HP servers.

bb-Ricardo commented 3 months ago

Hi,

did you try to set the alarms to "repaired" in the system log view?

Gibheer commented 3 months ago

If the alarms are set to repaired, it works, but we have a ton of servers with years old log entries, which means that thousands of alarms were reported. When setting the critical and warning to, e.g. 14 days, shouldn't it then ignore everything older than 14 days? Thats at least how we understood the documentation.

bb-Ricardo commented 3 months ago

Unfortunately I'm not able to just change this behaviour as it would break current installations. I clarified this in the README of the next-release branch.

I know it shows a lot of "new" issues when you start monitoring systems which were running since years. We have way more than 1000 servers and had to "clean" up as well.

You could also keep the change in your branch and use your fork of the plugin.

What do you think?

Gibheer commented 3 months ago

It is your project and your policy, so I am fine with that :) Lets close this and I will clean all our servers logs.

Thank you very much for your time.