search

bb-Ricardo / check_redfish

A monitoring/inventory plugin to check components and health status of systems which support Redfish. It will also create a inventory of all components of a system.
MIT License
113 stars 34 forks source link

Ignoring older log entries with --sel fails on DL360 Gen10 #50

Closed jhofmueller closed 3 years ago

jhofmueller commented 3 years ago

Log entries from system event log (--sel) are of type "System" and hence excepted from the age check in the event.py module. This makes it impossible to set thresholds for these log entries.

bb-Ricardo commented 3 years ago

Hi, I don't really understand this issue.

What are you trying to do and what should be the expected outcome?

jhofmueller commented 3 years ago

I am trying to run a check like this

check_redfish.py -H IP_ADDR --sel -f AUTHFILE -w 3 -c 1

According to the README I should get OK and return value 0 since all log entries regarding errors/warnings are older than three days. Instead I get CRITICAL for an older log entry. I checked the code and found out that the age of a log entry is only checked if the event_type != "System". Check line 201 ff in cr_module/event.py

bb-Ricardo commented 3 years ago

Ah, HPE has this great feature of marking events in SEL as "repaired". Just log in to your ILO and set the entries as repaired, alarm will be gone.

This is a great feature but only HPE provides this for IML.

bb-Ricardo commented 3 years ago

Did my suggestion solve your issue?

jhofmueller commented 3 years ago

Yes, that works!