Should this read vars.redfish_warning?

bb-Ricardo / check_redfish

A monitoring/inventory plugin to check components and health status of systems which support Redfish. It will also create a inventory of all components of a system.

MIT License

110 stars 30 forks source link

Should this read vars.redfish_warning? #92

Closed dorkmaneuver closed 1 year ago

dorkmaneuver commented 2 years ago

https://github.com/bb-Ricardo/check_redfish/blob/e55dd688e614a6e93abc361de171ff309cef8dee/contrib/icinga2_hw_service_checks_example.conf#L73

Maybe the lines 73 an 72 should read vars.redfish_warning = 3 vars.redfishcritical = 1 Or this must be changed in the command.conf in order to work. But putting vars.redfish... would follow the general conventions of Icinga and this plugin.

Thanks so much for your excellent work! Highly appreciated and happy to contribute a little bit. :)

Cheers!

bb-Ricardo commented 1 year ago

Hi,

thank you for this hint. Indeed it is wrong and I just pushed a fix to next-release branch.