bb-Ricardo / netbox-sync

Sync objects from VMware or redfish sources to NetBox
MIT License
282 stars 65 forks source link

Proposal: Introduce Custom Field for BMC Power Status in Netbox-sync #379

Open sh0x opened 6 months ago

sh0x commented 6 months ago

Issue

Currently, in Netbox-sync, the BMC power status is synchronized with the management status in Netbox. While Netbox's management status is designed for inventory provisioning purposes (Offline, Active, Planned, Staged, Failed, Inventory), it's being utilized by netbox-sync to represent the server power status.

https://github.com/bb-Ricardo/netbox-sync/blob/main/module/sources/check_redfish/import_inventory.py#L217

Proposal

I suggest implementing a custom field specifically for the BMC power status instead of repurposing the device management status field. This separation would maintain clarity and prevent the BMC power status from conflating with device management statuses.

Reasoning

By introducing a dedicated field for BMC power status, we ensure that both the server's operational state and its management status remain distinct and accurately represented within Netbox. This separation enhances clarity and avoids potential confusion or misinterpretation of device statuses.

Benefits

  1. Clarity: Users can easily differentiate between the server's power status and its management status, facilitating better understanding and management of devices.
  2. Flexibility: Having a custom field allows for future expansions or modifications specific to BMC power status without impacting other aspects of device management.
  3. Consistency: Adhering to Netbox's intended use of management status promotes consistency across the platform and aligns with established conventions.

Conclusion

By implementing a dedicated field for BMC power status, we can enhance the clarity and maintain the integrity of device management within Netbox, ensuring a more intuitive and efficient experience for users.

bb-Ricardo commented 6 months ago

Hi,

This sounds reasonable, will try to change this behavior as described.