bb-qq / r8152

Synology DSM driver for Realtek RTL8152/RTL8153/RTL8156 based adapters
GNU General Public License v2.0
2.07k stars 184 forks source link

Privilege escalation with DSM7 #146

Closed Benares1 closed 3 years ago

Benares1 commented 3 years ago

bb-qq did a lot of work to establish privilege escalation for DSM7 with spk_su.c

Isn't it possible to make this much more easier by using a ctrl-script section in conf/privilege? I saw this with other packages like FileStation ...

"defaults":{ "run-as": "package" }, "ctrl-script":[{ "action": "postinst", "run-as": "root" }, { "action": "preinst", "run-as": "root" }, { "action": "postuninst", "run-as": "root" }, { "action": "postupgrade", "run-as": "root" }, { "action": "preupgrade", "run-as": "root" }, { "action": "start", "run-as": "root" }, { "action": "stop", "run-as": "root" }, { "action": "status", "run-as": "root" }], ...

bb-qq commented 3 years ago

"run-as": "root" configuration is only allowed to Synology packages. Please see #137 for details. If you have further questions, please feel free to re-open this issue.