bb-qq / r8152

Synology DSM driver for Realtek RTL8152/RTL8153/RTL8156 based adapters
GNU General Public License v2.0
1.9k stars 178 forks source link

Not support DSM7.2 BETA #294

Closed skysolf closed 1 year ago

skysolf commented 1 year ago

synology ds920+ dsm version: 7.2 beta

not support on dsm 7.2,please fix it.tks.

Sjekke commented 1 year ago

not support on dsm 7.2,please fix it.tks.

Try to stay polite. And why should he support a beta that can change tomorrow.

skysolf commented 1 year ago

I don't mean any impoliteness, I just hope that the author can adapt the driver of version 7.2, after all, 7.2 will be officially released sooner or later. That's all, sorry if I made you feel rude.

MilesTEG1 commented 1 year ago

An update for the upcoming DSM 7.2 will be great. I hope it will come soon enough.

peterywong commented 1 year ago

Yes, an update for 7.2 would be awesome and greatly appreciated.

almir1904 commented 1 year ago

@skysolf I forked the original and made a DSM 7.2 Version for the DS920+ https://github.com/almir1904/r8152/releases/download/2.16.3-3/r8152-geminilake-2.16.3-3.spk

image

MilesTEG1 commented 1 year ago

@skysolf I forked the original and made a DSM 7.2 Version for the DS920+ https://github.com/almir1904/r8152/releases/download/2.16.3-3/r8152-geminilake-2.16.3-3.spk

image

You should do a PR here with your changes :)

Edit: what did you changes ?

almir1904 commented 1 year ago

@MilesTEG1 I just used the new Toolchain and rebuild the current package.

peterywong commented 1 year ago

@MilesTEG1 I just used the new Toolchain and rebuild the current package.

Any tips for doing that with ds919+?

Sjekke commented 1 year ago

@MilesTEG1 I just used the new Toolchain and rebuild the current package.

Any tips for doing that with ds919+?

You mean ds1019+? Ds919+ doesn't exist I think ...

peterywong commented 1 year ago

@MilesTEG1 I just used the new Toolchain and rebuild the current package.

Any tips for doing that with ds919+?

You mean ds1019+? Ds919+ doesn't exist I think ...

Sorry, I meant DS918+

almir1904 commented 1 year ago

https://help.synology.com/developer-guide/getting_started/first_package.html

I used this guide for it.

This are my commands

mkdir -p /toolkit apt-get install cifs-utils python3 python3-pip git git clone https://github.com/SynologyOpenSource/pkgscripts-ng cd /toolkit/pkgscripts-ng/ git checkout DSM7.2 ./EnvDeploy -v 7.2 -p geminilake (replace it with your CPU GEN) mkdir source cd source/ git clone https://github.com/bb-qq/r8152.git cd /toolkit/pkgscripts-ng/ ./PkgCreate.py -v 7.2 -p geminilake -c r8152

peterywong commented 1 year ago

https://help.synology.com/developer-guide/getting_started/first_package.html

I used this guide for it.

This are my commands

mkdir -p /toolkit apt-get install cifs-utils python3 python3-pip git git clone https://github.com/SynologyOpenSource/pkgscripts-ng cd /toolkit/pkgscripts-ng/ git checkout DSM7.2 ./EnvDeploy -v 7.2 -p geminilake (replace it with your CPU GEN) mkdir source cd source/ git clone https://github.com/bb-qq/r8152.git cd /toolkit/pkgscripts-ng/ ./PkgCreate.py -v 7.2 -p geminilake -c r8152

Thanks

peterywong commented 1 year ago

After building the new package for my NAS, I get "invalid file format" with my spk file. Have you seen this before?

almir1904 commented 1 year ago

@peterywong can you open the package with a text editor and check if there is a os_min_ver around line 7

peterywong commented 1 year ago

This is what I have in the INFO file package="r8152" version="2.16.3-3" maintainer="bb-qq" arch="apollolake" install_type="package" thirdparty="yes" description="Realtek RTL8152/RTL8153 Based USB Ethernet Adapters driver." displayname="RTL8152/RTL8153 driver" extractsize="1564" toolkit_version="63133" create_time="20230316-23:44:48"

skysolf commented 1 year ago

@skysolf

I forked the original and made a DSM 7.2 Version for the DS920+

https://github.com/almir1904/r8152/releases/download/2.16.3-3/r8152-geminilake-2.16.3-3.spk

image

Awesome,tks a lot

peterywong commented 1 year ago

Looks like the solution was to update INFO.sh before building the file.

peterywong commented 1 year ago

Here's my build for DS918+ https://github.com/peterywong/r8152/releases/download/2.16.3-3/r8152-apollolake-2.16.3-3.spk

TheS1R commented 1 year ago

Is this working for you with DSM 7.2 on DS918+? I have DS718+ (also apollolake), but I have held off on updating to DSM 7.2 until the driver works.

peterywong commented 1 year ago

Is this working for you with DSM 7.2 on DS918+? I have DS718+ (also apollolake), but I have held off on updating to DSM 7.2 until the driver works.

Yes, It's working on my DS918+ with 7.2 beta.

noblemd00 commented 1 year ago

I used almir1904's file to install the package on a DS1520+ (also geminilake processor) and it worked like a charm. Thanks!

I'm going to investigate and hope to do what you did for the r8152 for the 5G AQC111 adapter (also by bb-qq). which worked on my 1520 before DSM 7.2 . Have no prior experience making/writing Synology packages so not sure about doing it!

TheS1R commented 1 year ago

@peterywong Your apollolake image works for me as well on two different DS718+ units. Thanks for doing the legwork and saving me tons of time!

halden2714 commented 1 year ago

Here's my build for DS918+ https://github.com/peterywong/r8152/releases/download/2.16.3-3/r8152-apollolake-2.16.3-3.spk

Your build works like a charm for me on DS418Play!!! Much obliged... :)))

bb-qq commented 1 year ago

Thank you for trying everything about DSM7.2. I created packages based on information on this issue. Please try this and let me know if it works. https://github.com/bb-qq/r8152/releases/tag/2.16.3-4

blasiusx commented 1 year ago

Thank you very much, bb-qq, and all others. :-)

ganyuansi commented 1 year ago

Thank you for trying everything about DSM7.2. I created packages based on information on this issue. Please try this and let me know if it works. https://github.com/bb-qq/r8152/releases/tag/2.16.3-4

Thank you,My DS920+ update to DMS 7.2 beta,for test work good!my used [UGREEN USB A to 2.5G Ethernet Adapter]

bb-qq commented 1 year ago

Thanks for the report. It seems to be working fine, so I will close this issue.